From 9b6e17918f880de2b9517fd6c03e31eb985ab6a9 Mon Sep 17 00:00:00 2001 From: Thibault Barnouin Date: Mon, 2 Jun 2025 12:25:00 +0200 Subject: [PATCH] fix default plot value in emission_center, value ranges in interactive SNR --- package/lib/plots.py | 8 ++++---- package/src/emission_center.py | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package/lib/plots.py b/package/lib/plots.py index 1c9e5a0..c5480c6 100755 --- a/package/lib/plots.py +++ b/package/lib/plots.py @@ -2464,9 +2464,9 @@ class pol_map(object): ax_snr_conf = self.fig.add_axes([0.115, 0.020, 0.05, 0.02]) SNRi_max = np.max(self.I[self.IQU_cov[0, 0] > 0.0] / np.sqrt(self.IQU_cov[0, 0][self.IQU_cov[0, 0] > 0.0])) SNRp_max = np.max(self.P[self.P_ERR > 0.0] / self.P_ERR[self.P_ERR > 0.0]) - s_I_cut = Slider(ax_I_cut, r"$SNR^{I}_{cut}$", 1.0, int(SNRi_max * 0.95), valstep=1, valinit=self.SNRi_cut) + s_I_cut = Slider(ax_I_cut, r"$SNR^{I}_{cut}$", 1.0, int(SNRi_max * 0.95), valstep=0.5, valinit=self.SNRi_cut) self.P_ERR_cut = Slider( - self.ax_P_cut, r"$Conf^{P}_{cut}$", 0.50, 1.0, valstep=[0.500, 0.900, 0.990, 0.999], valinit=self.P_cut if P_cut <= 1.0 else 0.99 + self.ax_P_cut, r"$Conf^{P}_{cut}$", 0.50, 1.0, valstep=[0.500, 0.675, 0.900, 0.990, 0.999], valinit=self.P_cut if P_cut <= 1.0 else 0.99 ) s_vec_sc = Slider(ax_vec_sc, r"Vec scale", 0.0, 10.0, valstep=1, valinit=self.scale_vec) b_snr_reset = Button(ax_snr_reset, "Reset") @@ -2505,13 +2505,13 @@ class pol_map(object): self.snr_conf = 0 b_snr_conf.label.set_text("Conf") self.P_ERR_cut = Slider( - self.ax_P_cut, r"$SNR^{P}_{cut}$", 1.0, max(int(SNRp_max * 0.95), 3), valstep=1, valinit=self.P_cut if P_cut >= 1.0 else 3 + self.ax_P_cut, r"$SNR^{P}_{cut}$", 1.0, max(int(SNRp_max * 0.95), 3), valstep=0.5, valinit=self.P_cut if P_cut >= 1.0 else 3 ) else: self.snr_conf = 1 b_snr_conf.label.set_text("SNR") self.P_ERR_cut = Slider( - self.ax_P_cut, r"$Conf^{P}_{cut}$", 0.50, 1.0, valstep=[0.500, 0.900, 0.990, 0.999], valinit=self.P_cut if P_cut <= 1.0 else 0.99 + self.ax_P_cut, r"$Conf^{P}_{cut}$", 0.50, 1.0, valstep=[0.500, 0.6750, 0.900, 0.990, 0.999], valinit=self.P_cut if P_cut <= 1.0 else 0.99 ) self.P_ERR_cut.on_changed(update_snrp) update_snrp(self.P_ERR_cut.val) diff --git a/package/src/emission_center.py b/package/src/emission_center.py index 6e3b892..7a7908b 100755 --- a/package/src/emission_center.py +++ b/package/src/emission_center.py @@ -77,10 +77,10 @@ if __name__ == "__main__": parser = argparse.ArgumentParser(description="Look for the center of emission for a given reduced observation") parser.add_argument("-t", "--target", metavar="targetname", required=False, help="the name of the target", type=str, default=None) - parser.add_argument("-f", "--file", metavar="path", required=False, help="The full or relative path to the data product", type=str, default=None) - parser.add_argument("-c", "--pcut", metavar="pcut", required=False, help="The polarization cut for the data mask", type=float, default=0.99) + parser.add_argument("-f", "--file", metavar="path", required=True, help="The full or relative path to the data product", type=str, default=None) + parser.add_argument("-c", "--pcut", metavar="pcut", required=False, help="The polarization cut for the data mask", type=float, default=3.0) parser.add_argument("-d", "--display", metavar="display", required=False, help="The map on which to display info", type=str, default="pf") - parser.add_argument("-o", "--output_dir", metavar="directory_path", required=False, help="output directory path for the plots", type=str, default="./data") + parser.add_argument("-o", "--output_dir", metavar="directory_path", required=False, help="output directory path for the plots", type=str, default=None) args = parser.parse_args() exitcode = main(infile=args.file, P_cut=args.pcut, target=args.target, display=args.display, output_dir=args.output_dir) print("Written to: ", exitcode)